Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3120 +/- ##
==========================================
+ Coverage 93.26% 93.28% +0.01%
==========================================
Files 493 493
Lines 45615 45711 +96
Branches 6254 6264 +10
==========================================
+ Hits 42545 42643 +98
+ Misses 1983 1982 -1
+ Partials 1087 1086 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Other minor issues: WIP commit message OIDC_INVALID_ID_TOKEN_HINT removal Test coverage for post_logout_redirect_uri validation Documentation for revocation_endpoint |
dbernstein
left a comment
There was a problem hiding this comment.
Hi @tdilauro : this looks great overall. I'm giving it the thumbs up. There are some minor comments to consider.
There is one issue that I believe should be addressed before merging: ie validating the redirect url. But I leave it to you to make the call.
13df2ba to
4526235
Compare
96d13a5 to
d4c0f63
Compare
Description
Improves the initial OIDC RP-Initiated Logout flow with several enhancements:
AuthorizationBearer header rather than requiring the client to pass an id_token_hint query parameter. This avoids a DB lookup that would fail after token refresh (since the credential value changes on refresh but the patron's bearer token still holds the old value).Motivation and Context
Fixes and extends the OIDC logout flow introduce with the initial OIDC implementation. The original implementation required clients to pass an id_token_hint, which was fragile after token refresh (the stored credential changes but the patron's bearer token does not). This rework makes logout more reliable and self-contained, using only the bearer token already required for authenticated requests.
Also addresses a performance issue where the OIDC discovery document was being fetched on every request to get_authentication_manager().
[Jira PP-3726]
How Has This Been Tested?
Checklist